bugfix: Don't use fullclasspath in sbt plugin #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, I used fullclasspath for getting the runtime classpath, but I forgot this causes sbt to always compile on bloopInstaall. Now, I changed to use the same mechanism we use for compile classpath and added a test to make sure this doesn't show up again.
adpi2
reviewed
Nov 23, 2023
Comment on lines
+1
to
+3
| > bloopGenerate | ||
| > test:bloopGenerate | ||
| > checkBloopFiles |
There was a problem hiding this comment.
How does this test check that the compilation is not triggered?
There was a problem hiding this comment.
What we really want to check is that the files are properly generated despite the error. Previously, when we used fullclasspath the bloopInstall task itself would fail and nothing would get generated
There was a problem hiding this comment.
Oh I see there is an error in the Obj.scala file
adpi2
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, I used fullclasspath for getting the runtime classpath, but I forgot this causes sbt to always compile on bloopInstaall.
Now, I changed to use the same mechanism we use for compile classpath and added a test to make sure this doesn't show up again.