Revert "Merge pull request #2128 from Arthurm1/specify_javac_target_root" #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ac_target_root" This reverts commit a3a78de, reversing changes made to 041a90b. It seems to have caused scalacenter#2140
|
CC @Arthurm1 Looks like this is actually being used when caching zinc analysis and each time we recompile the correct previous analysis is not being read. So unfortunately we can't use that approach :/ |
|
Will go ahead and merge this to test in Metals and locally. |
|
@tgodzik damn - sorry. I'll look to see if there's another way of doing this |
No worries, I will just release a new version tomorrow. I am highly surprised that none of the tests picked up on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a3a78de, reversing changes made to 041a90b.
It seems to have caused #2140