Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop shading stuff in sbt-bloop plugins #1754

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Stop shading stuff in sbt-bloop plugins #1754

merged 1 commit into from
Jul 26, 2022

Conversation

alexarchambault
Copy link
Contributor

@alexarchambault alexarchambault commented Jul 5, 2022 •
edited
Loading

Fixes #1752.

@alexarchambault alexarchambault marked this pull request as draft July 5, 2022 07:40
@alexarchambault alexarchambault mentioned this pull request Jul 5, 2022
Merged
@alexarchambault alexarchambault force-pushed the sbt-bloop-no-shading branch 2 times, most recently from 1650ed6 to c8a0bb5 Compare July 5, 2022 09:04
@alexarchambault
Copy link
Contributor Author

alexarchambault commented Jul 5, 2022 •
edited
Loading

Merging scalacenter/compiler-benchmark#8 is required for the CI here to have a chance to be green (I guess scalacenter/compiler-benchmark#8 can always be reverted by a force push later on if the PR here ends up not being merged.)

@alexarchambault alexarchambault marked this pull request as ready for review July 5, 2022 09:15
@tgodzik
Copy link
Contributor

tgodzik commented Jul 5, 2022

Merging scalacenter/compiler-benchmark#8 is required for the CI here to have a chance to be green (I guess scalacenter/compiler-benchmark#8 can always be reverted by a force push later on if the PR here ends up not being merged.)

Thanks! Done!

@alexarchambault alexarchambault force-pushed the sbt-bloop-no-shading branch 2 times, most recently from 59dd6aa to f0b2d6d Compare July 5, 2022 15:29
@alexarchambault
Stop shading stuff in sbt-bloop plugins
584384c 
They mainly depend on bloop-config and jsoniter-scala, which should be
stable enough.
@alexarchambault
Copy link
Contributor Author

@tgodzik CI seems to be green. This could be merged if that looks fine to everyone.

tgodzik
tgodzik approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks and sorry I forgot about it!

@tgodzik tgodzik merged commit a4a940e into scalacenter:main Jul 26, 2022
@alexarchambault alexarchambault deleted the sbt-bloop-no-shading branch July 31, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop using shading for sbt-bloop modules
2 participants
@alexarchambault @tgodzik