Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: break CI actions into smaller pieces #1706

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

kpodsiad
Copy link
Collaborator

I removed onload resources generation and then I extracted two additional actions on CI.
Finer grained CI actions should reduce main tests duration and provide a better experience when debugging CI.

@kpodsiad kpodsiad requested a review from tgodzik March 28, 2022 10:49
@kpodsiad
Copy link
Collaborator Author

Before
Screenshot 2022-03-28 at 15 24 12
After
Screenshot 2022-03-28 at 15 24 18

Although these are statistics from a single run they indicate that CI jobs on GraalVM are a bit faster. The most gain can be observed on the slowest windows so it's a double win.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach looks sensible, thanks for looking into that.

bin/setup-test-projects.sh Outdated Show resolved Hide resolved
docs/contributing-guide.md Outdated Show resolved Hide resolved
@dos65
Copy link
Collaborator

dos65 commented Apr 1, 2022

@kpodsiad I did an alternative fix for this in #1708

@kpodsiad kpodsiad force-pushed the chore/faster-sbt-load branch 2 times, most recently from 3f59b08 to a94128b Compare April 5, 2022 07:17
@kpodsiad kpodsiad force-pushed the chore/faster-sbt-load branch from a94128b to 41c2614 Compare April 5, 2022 07:21
@tgodzik
Copy link
Contributor

tgodzik commented Apr 7, 2022

@kpodsiad looks like we can close this one?

@kpodsiad
Copy link
Collaborator Author

kpodsiad commented Apr 7, 2022

Actually, after #1708 was merged I pivoted into breaking CI actions into smaller pieces. I think it will be valuable to have more fine-grained actions which are responsible only for testing something more narrow than currently.

#1708 won't regenerate bloop config if it was removed from e.g. one directory but #1715 fixes it.

@kpodsiad kpodsiad changed the title tweak CI actions/remove onload resources generation ci: break CI actions into smaller pieces Apr 9, 2022
@kpodsiad kpodsiad requested a review from tgodzik April 9, 2022 10:13
@kpodsiad
Copy link
Collaborator Author

@tgodzik wdyt?

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kpodsiad kpodsiad merged commit 3cdeef0 into scalacenter:main Apr 14, 2022
@kpodsiad kpodsiad deleted the chore/faster-sbt-load branch April 14, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants