Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust scala test classes bsp endpoint #1695

Merged
merged 6 commits into from
Mar 14, 2022

Conversation

kpodsiad
Copy link
Collaborator

I've added [skip ci] because there's no point in wasting resources now.

It is an implementation of BSP proposal which is described here.

@kpodsiad kpodsiad force-pushed the feat/scala-test-classes branch from fe213b8 to 699fb50 Compare March 11, 2022 13:30
@kpodsiad kpodsiad marked this pull request as ready for review March 13, 2022 06:13
@kpodsiad kpodsiad requested a review from tgodzik March 13, 2022 06:13
@kpodsiad
Copy link
Collaborator Author

CI is green 🥳

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kpodsiad kpodsiad merged commit 2580f21 into scalacenter:main Mar 14, 2022
@kpodsiad kpodsiad deleted the feat/scala-test-classes branch March 14, 2022 12:16
lefou pushed a commit to com-lihaoyi/mill that referenced this pull request Apr 26, 2022
It is an implementation of the BSP proposal which is described in build-server-protocol/build-server-protocol#296 (comment). This proposal adds an optional framework field to the returned class.

There's already implementation for bloop: scalacenter/bloop#1695

Also added `debugSessionStart` endpoint.

Pull request: #1755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants