Support runtime JDK config #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duhemm
added
task / compile
task / run
task / test
configuration format
olafurpg
reviewed
Oct 22, 2020
| """/a/A.scala | ||
| |object A { | ||
| | def main(args: Array[String]): Unit = { | ||
| | assert("goodbye" == sys.props("test")) |
There was a problem hiding this comment.
It might be tricky to implement, but how hard would it be to assert that the runtime property is not available at compile-time?
There was a problem hiding this comment.
It would be difficult to test, because we fork compilation only for Java, and under certain conditions only (ie. the Java home is different from the current Java). I guess we'd need a Java annotation processor that would check for the property?
Duhemm
force-pushed
the
runtime-platform
branch
from
f03f701 to
bbf43b9
Compare
Previously, Bloop would support only a single JDK configuration per project, which would apply to both compile-time and runtime. However, some tools (e.g. Pants) support defining a different JDK configuration for compile-time and runtime. To be able to export faithfully builds from these tools, Bloop needs to support this kind of configuration as well. This commit adds a new field, `runtimeConfig`, to JVM projects' `platform` configuration, which has the same schema as the existing `config`. The `config` is used to configure the compile-time configuration, whereas `runtimeConfig` is used for runtime. When `runtimeConfig` doesn't exist, Bloop falls back to `config`.
Duhemm
force-pushed
the
runtime-platform
branch
from
bbf43b9 to
266245b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Bloop would support only a single JDK configuration per
project, which would apply to both compile-time and runtime. However,
some tools (e.g. Pants) support defining a different JDK configuration
for compile-time and runtime.
To be able to export faithfully builds from these tools, Bloop needs to
support this kind of configuration as well. This commit adds a new
field,
runtimeConfig, to JVM projects'platformconfiguration, whichhas the same schema as the existing
config.The
configis used to configure the compile-time configuration,whereas
runtimeConfigis used for runtime. WhenruntimeConfigdoesn't exist, Bloop falls back to
config.