Increase maximum depth for quick-select to 16

CHANGELOG.unreleased.md

@@ -44,6 +44,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released
 - The overall performance was improved (especially for the segments tab). [#7958](https://github.com/scalableminds/webknossos/pull/7958)
 - The performance for the skeleton tab was improved. [#7989](https://github.com/scalableminds/webknossos/pull/7989)
 - Upgraded ant icons to version 5.4. [#8007](https://github.com/scalableminds/webknossos/pull/8007)
+- Increased maximum depth for ai-based quick select from 5 to 16. [#8021](https://github.com/scalableminds/webknossos/pull/8021)
 - Zarr-streaming now uses the new unit-aware voxel size. This means that [wk-libs client v0.14.25 or newer](https://github.com/scalableminds/webknossos-libs/releases) is needed for dataset zarr streaming. [#8012](https://github.com/scalableminds/webknossos/pull/8012)
 
 ### Fixed

app/controllers/DatasetController.scala

@@ -418,7 +418,9 @@ class DatasetController @Inject()(userService: UserService,
           datastoreClient <- datasetService.clientFor(dataset)(GlobalAccessContext)
           targetMagSelectedBbox: BoundingBox = request.body.surroundingBoundingBox / request.body.mag
           _ <- bool2Fox(targetMagSelectedBbox.size.sorted.z <= 1024 && targetMagSelectedBbox.size.sorted.y <= 1024) ?~> s"Target-mag selected bbox must be smaller than 1024×1024×depth (or transposed), got ${targetMagSelectedBbox.size}"
-          _ <- bool2Fox(targetMagSelectedBbox.size.sorted.x <= 12) ?~> s"Target-mag selected bbox depth must be at most 12"
+          // The maximum depth of 16 also needs to be adapted in the front-end
+          // (at the time of writing, in MAX_DEPTH_FOR_SAM in quick_select_settings.tsx).
+          _ <- bool2Fox(targetMagSelectedBbox.size.sorted.x <= 16) ?~> s"Target-mag selected bbox depth must be at most 16"
           _ <- bool2Fox(targetMagSelectedBbox.size.sorted.z == targetMagSelectedBbox.size.sorted.y) ?~> s"Target-mag selected bbox must equally sized long edges, got ${targetMagSelectedBbox.size}"
           _ <- Fox.runIf(request.body.interactionType == SAMInteractionType.BOUNDING_BOX)(
             bool2Fox(request.body.selectionTopLeftX.isDefined &&

frontend/javascripts/oxalis/model/sagas/quick_select_ml_saga.ts

@@ -257,17 +257,22 @@ export default function* performQuickSelect(
     const userBoxRelativeToMaskInMag = userBoxInMag.offset(V3.negate(maskBoxInMag.min));
 
     let wOffset = 0;
+    const currentEstimationInputForBBoxEstimation = {
+      min: userBoxRelativeToMaskInMag.getMinUV(activeViewport),
+      max: userBoxRelativeToMaskInMag.getMaxUV(activeViewport),
+    };
     for (const mask of masks) {
       const targetW = alignedUserBoxMag1.min[thirdDim] + labeledResolution[thirdDim] * wOffset;
 
       const { min: minUV, max: maxUV } = estimateBBoxInMask(
         mask,
-        {
-          min: userBoxRelativeToMaskInMag.getMinUV(activeViewport),
-          max: userBoxRelativeToMaskInMag.getMaxUV(activeViewport),
-        },
+        currentEstimationInputForBBoxEstimation,
         MAXIMUM_PADDING_ERROR,
       );
+      // Use the estimated bbox as input for the next iteration so that
+      // moving segments don't "exit" the used bbox at the some point in W.
+      currentEstimationInputForBBoxEstimation.min = minUV;
+      currentEstimationInputForBBoxEstimation.max = maxUV;
 
       // Span a bbox from the estimated values (relative to the mask)
       // and move it by the mask's min position to achieve a global

frontend/javascripts/oxalis/view/action-bar/quick_select_settings.tsx

@@ -17,6 +17,10 @@ import features from "features";
 import FastTooltip from "components/fast_tooltip";
 import { QuestionCircleOutlined } from "@ant-design/icons";
 
+// The maximum depth of 16 also needs to be adapted in the back-end
+// (at the time of writing, in segmentAnythingMask in DatasetController.scala).
+const MAX_DEPTH_FOR_SAM = 16;
+
 const OPTIONS_WITH_DISABLED = [
   { label: "Dark Segment", value: "dark" },
   { label: "Light Segment", value: "light" },
@@ -73,7 +77,7 @@ export function AiQuickSelectControls() {
         label="Prediction Depth"
         min={1}
         value={quickSelectConfig.predictionDepth || 1}
-        max={5}
+        max={MAX_DEPTH_FOR_SAM}
         step={1}
         onChange={onChangePredictionDepth}
       />