Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow negative min / max values for floating point color layers #7873

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Allow negative min / max values for floating point color layers #7873

merged 2 commits into from
Jun 10, 2024

Conversation

MichaelBuessemeyer
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer commented Jun 10, 2024 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Open a dataset with floating point layers
  • Try to configure negative values for min and max (min needs to be lowered first). This should work.

Issues:

(Please delete unneeded items, merge only when none are left open)

@MichaelBuessemeyer MichaelBuessemeyer self-assigned this Jun 10, 2024
@MichaelBuessemeyer MichaelBuessemeyer marked this pull request as ready for review June 10, 2024 13:10
@MichaelBuessemeyer MichaelBuessemeyer merged commit 052c0c7 into master Jun 10, 2024
2 checks passed
@MichaelBuessemeyer MichaelBuessemeyer deleted the allow-negative-min-max-values-for-floating-layers branch June 10, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normanrz normanrz normanrz approved these changes

Assignees

@MichaelBuessemeyer MichaelBuessemeyer

Labels
enhancement frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Min/max need to support negative values for signed datatypes
2 participants
@MichaelBuessemeyer @normanrz