Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard annotation list: skip deleted annotations #7628

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Feb 15, 2024

The annotation list attempted to include deleted annotations, which fails in the frontend, since some properties may become null.

Was a regression introduced in #7410


@fm3 fm3 self-assigned this Feb 15, 2024
@fm3 fm3 marked this pull request as ready for review February 15, 2024 09:55
@fm3 fm3 enabled auto-merge (squash) February 15, 2024 09:55
@fm3 fm3 merged commit 6ac0a01 into master Feb 15, 2024
2 checks passed
@fm3 fm3 deleted the do-not-list-deleted-annotations branch February 15, 2024 10:12
philippotto pushed a commit that referenced this pull request Feb 15, 2024
* Dashboard annotation list: skip deleted annotations

* num in changelog
@philippotto philippotto mentioned this pull request Feb 15, 2024
philippotto added a commit that referenced this pull request Feb 15, 2024
* Dashboard annotation list: skip deleted annotations (#7628)

* Dashboard annotation list: skip deleted annotations

* num in changelog

* Release 24.02.1

---------

Co-authored-by: Florian M <[email protected]>
philippotto added a commit that referenced this pull request Feb 19, 2024
* Dashboard annotation list: skip deleted annotations (#7628)

* Dashboard annotation list: skip deleted annotations

* num in changelog

* Release 24.02.1

* Fix sql error in annotation list query (#7632)

* Release 24.02.2

---------

Co-authored-by: Florian M <[email protected]>
fm3 added a commit that referenced this pull request Feb 22, 2024
* Dashboard annotation list: skip deleted annotations (#7628)

* Dashboard annotation list: skip deleted annotations

* num in changelog

* Release 24.02.1

* Fix sql error in annotation list query (#7632)

* Release 24.02.2

* Release 24.02.3

* Apply suggestions from code review

Co-authored-by: Philipp Otto <[email protected]>

---------

Co-authored-by: Philipp Otto <[email protected]>
Co-authored-by: Philipp Otto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants