-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional axes bounds as semi-open interval #7547
Conversation
@markbader could you comment if this works with scalableminds/webknossos-libs#966 or if you need anything else from us to adapt it? :) |
Co-authored-by: frcroth <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
front-end also looks good to me 👍
I guess it's not worth it to make the migration idempotent?
Shouldn’t think so. If it does fail, we have the .bak files. There aren’t hundreds of nd datasets in the first place |
@fm3 For wklibs these changes are fine, and I currently don't need anything else to be adapted. Thanks! |
We decided to change the format for additionalAxes in the datasource-properties: the upper bound is now exclusive. That is now also used for volume annotations and in the NML format.
Steps to test:
TODOs:
Issues: