Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs related to mesh loading and short links #7507

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Dec 20, 2023

This PR fixes three issues.

  1. Fixed a bug where loaded meshes were not encoded in the sharing link.
  2. Fixed a bug where meshes (or chunks of them) were always colored white, if they were loaded while the corresponding segmentation layer was disabled.
  3. Fixed a race condition when opening a short link, that would sometimes lead to an error toast.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Open the dev tools
  • Load a mesh, disable the segmentation layer and copy the sharing link. When opening the sharing link, the mesh should be loaded and it should have the corresponding segment's color (not white!).
  • Check the network tab of the dev tools after opening a short link. There should only be a single request to api/shortLinks/byKey/.... Before, there was a second request to /api/shortLinks/byKey/https: which led to an error toast, sometimes.

Issues:


(Please delete unneeded items, merge only when none are left open)

@daniel-wer daniel-wer self-assigned this Dec 20, 2023
@daniel-wer daniel-wer changed the title [WIP] White mesh bug Fix bugs related to mesh loading and short links Dec 20, 2023
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for fixing these 👍 Works well!

@daniel-wer daniel-wer merged commit 8d64194 into master Dec 20, 2023
2 checks passed
@daniel-wer daniel-wer deleted the white-mesh-bug branch December 20, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mesh chunks loaded while the segmentation layer is disabled are always white
2 participants