Avoid errors on zarr dataset settings page #7475
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The settings page calls the datastore route
GET /datasets/:organizationName/:dataSetName
which traverses the files and makes automatic suggestions for the datasource-properties.json. This works only for WKW and was originally designed also as an import step (when dataset creators didn’t write their own datasource-properties.jsons).This PR skips this step for Zarr and presents a warning instead of a ton of errors (that were there before because the data didn’t match the WKW format).
We can later decide if we want to implement this also for other dataformats like zarr. It could reuse the explore code that is used for remote datasets. However, the suggestions might be imperfect there, as the original datasource-properties.jsons might contain more relevant information that can be inferred from just the zarr array files.
We might also want to discontinue this feature altogether, as zarr becomes more common and datasets are usually either explored remotely (uses the explore code), created via the libs (should already have good datasource-properties.json) or uploaded using the web upload (has its own version of this feature as of #7397). I created follow-up discussion issue #7474 for that
Steps to test:
Issues: