Fix cursor jumping bug in tree and comment renaming #7390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7136 removed a workaround for cursor jumping, because I thought that react v16 would have fixed this. During testing, I assumed that all inputs would suffer from this bug, but it turns out that only controlled inputs that store their state in the store (and not in a local state) are affected. I think, this is only true for the tree name and comment inputs which is likely why I missed this back then.
I re-introduced the bug fix and removed the
isFocused
handling, since that assumed that the input's content should not update when the input is changed from the outside while it's focussed. However, the dataset position view supports changing the input via the arrow-keys now which is not compatible with the isFocused check. I think the change should not cause any issues ™️URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)