Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reading zarr2 data with channel axis #7374

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Fix reading zarr2 data with channel axis #7374

merged 2 commits into from
Oct 10, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Oct 10, 2023 •
edited
Loading

readBytesWithAdditionalCoordinates does not do the dimension padding of the requested shape + offset. It should really only be used in the ND dataset case where all axes are present in the request.
Related #7280

Steps to test:

  • Try to load data from a zarr2 dataset that has a channel axis (but no additional coordinates), should see data
  • Updated changelog
  • Needs datastore update after deployment

@fm3 fm3 self-assigned this Oct 10, 2023
@fm3 fm3 changed the title Fix reading zarr2 data with channel Fix reading zarr2 data with channel axis Oct 10, 2023
@fm3 fm3 marked this pull request as ready for review October 10, 2023 10:06
@fm3 fm3 requested a review from frcroth October 10, 2023 10:06
@fm3 fm3 enabled auto-merge (squash) October 10, 2023 10:15
@fm3 fm3 merged commit b40678d into master Oct 10, 2023
1 check passed
@fm3 fm3 deleted the zarr2-padding-fix branch October 10, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frcroth frcroth frcroth approved these changes

Assignees

@fm3 fm3

Labels
backend bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fm3 @frcroth