Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading sharded zarr3 from local file system #7321

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Sep 7, 2023

The FileSystemVaultPath did not yet override readLastBytes, which is needed when reading zarr3 sharded datasets. Thus, the implementation of the parent class was used, which forwarded to readBytesAndEncoding, but that does not exist in the FileSystemDataVault.

Instead, now I implemented this in FileSystemVaultPath and adapted readBytesLocal to also support SuffixLength byte ranges.

Steps to test:

  • Open a locally stored zarr3 sharded dataset, should see data

  • Updated changelog
  • Needs datastore update after deployment

@fm3 fm3 requested a review from normanrz September 7, 2023 10:03
@fm3 fm3 self-assigned this Sep 7, 2023
@fm3 fm3 merged commit 4663114 into master Sep 7, 2023
1 check passed
@fm3 fm3 deleted the filesystemvault-read-last-bytes branch September 7, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants