Fix reading sharded zarr3 from local file system #7321
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FileSystemVaultPath did not yet override
readLastBytes
, which is needed when reading zarr3 sharded datasets. Thus, the implementation of the parent class was used, which forwarded toreadBytesAndEncoding
, but that does not exist in the FileSystemDataVault.Instead, now I implemented this in
FileSystemVaultPath
and adaptedreadBytesLocal
to also support SuffixLength byte ranges.Steps to test: