Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically assign color and channel name for omero ngff #7251

Merged
merged 9 commits into from
Aug 24, 2023
Merged

Automatically assign color and channel name for omero ngff #7251

merged 9 commits into from
Aug 24, 2023

Conversation

frcroth
Copy link
Member

@frcroth frcroth commented Aug 7, 2023 •
edited
Loading

URL of deployed dev instance (used for testing):

Steps to test:

Issues:

(Please delete unneeded items, merge only when none are left open)

  • Updated changelog
  • Needs datastore update after deployment

@frcroth frcroth self-assigned this Aug 8, 2023
@frcroth frcroth requested a review from fm3 August 8, 2023 07:38
@frcroth frcroth changed the title [WIP] Automatically assign color and channel name for omero ngff Automatically assign color and channel name for omero ngff Aug 8, 2023
@frcroth frcroth marked this pull request as ready for review August 8, 2023 07:39
@frcroth frcroth mentioned this pull request Aug 8, 2023
Merged
3 tasks
fm3
fm3 requested changes Aug 14, 2023
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good already :-) I added a few small suggestions

app/models/binary/explore/NgffExplorer.scala Outdated Show resolved Hide resolved
...sos-datastore/app/com/scalableminds/webknossos/datastore/datareaders/zarr/NgffMetadata.scala Outdated Show resolved Hide resolved
util/src/main/scala/com/scalableminds/util/image/Color.scala Outdated Show resolved Hide resolved
@frcroth frcroth requested a review from fm3 August 21, 2023 08:06
@frcroth frcroth merged commit 9e12cb4 into master Aug 24, 2023
1 check passed
@frcroth frcroth deleted the automatically-assign-color branch August 24, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

Assignees

@frcroth frcroth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatically assign colors for remote multi channel dataset
2 participants
@frcroth @fm3