Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use New Task Terminology in Code #7220

Merged
merged 18 commits into from
Aug 14, 2023
Merged

Use New Task Terminology in Code #7220

merged 18 commits into from
Aug 14, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jul 20, 2023

URL of deployed dev instance (used for testing):

Steps to test:

  • Create some tasks, request, trace finish, look at report pages, task list view, project list view, should all still look as expected

TODOs:

Issues:


@fm3 fm3 changed the title WIP: Use New Task Terminology in Code Use New Task Terminology in Code Jul 25, 2023
@fm3 fm3 marked this pull request as ready for review July 25, 2023 11:00
@fm3 fm3 requested a review from philippotto July 25, 2023 11:00
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks good 👍

However, one navbar link is broken (statistics > available tasks points to https://taskterminology.webknossos.xyz/reports/openTasks which is a 404).

also see my one question about pending vs available.

I did not review the SQL migration, as I don't feel confident enough to spot potential errors there. can @frcroth chime in for that review maybe?

app/controllers/TaskController.scala Show resolved Hide resolved
conf/webknossos.latest.routes Show resolved Hide resolved
@fm3 fm3 requested a review from philippotto July 27, 2023 10:45
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 leaving the final acceptance to @frcroth since I didn't review the migrations.

@philippotto philippotto requested a review from frcroth July 28, 2023 12:07
Copy link
Member

@frcroth frcroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sql could use comments, but looks consistent

@fm3 fm3 dismissed philippotto’s stale review August 14, 2023 07:45

(they commented above that it looks good now with feedback applied)

@fm3 fm3 enabled auto-merge (squash) August 14, 2023 08:53
@fm3 fm3 merged commit 3e7d250 into master Aug 14, 2023
1 check passed
@fm3 fm3 deleted the task-terminology branch August 14, 2023 09:10
@fm3 fm3 mentioned this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use new Task terminology also in code
4 participants