-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use New Task Terminology in Code #7220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly looks good 👍
However, one navbar link is broken (statistics > available tasks points to https://taskterminology.webknossos.xyz/reports/openTasks which is a 404).
also see my one question about pending vs available.
I did not review the SQL migration, as I don't feel confident enough to spot potential errors there. can @frcroth chime in for that review maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍 leaving the final acceptance to @frcroth since I didn't review the migrations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sql could use comments, but looks consistent
(they commented above that it looks good now with feedback applied)
URL of deployed dev instance (used for testing):
Steps to test:
TODOs:
Issues: