Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search for single-folder organizations #7177

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Fix search for single-folder organizations #7177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1ab167
never show placeholder during search
philippotto Jun 26, 2023
2d50c81
update changelog
philippotto Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.unreleased.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released

### Fixed
- Fixed rare rendering bug at viewport edge for anisotropic datasets. [#7163](https://github.com/scalableminds/webknossos/pull/7163)
- Fixed the dataset search which was broken when only the root folder existed. [#7177](https://github.com/scalableminds/webknossos/pull/7177)

### Removed

Expand Down
3 changes: 2 additions & 1 deletion frontend/javascripts/dashboard/dataset_folder_view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,8 @@ function DatasetFolderViewInner(props: Props) {
hierarchy.flatItems.length === 1 &&
context.datasets.length === 0 &&
context.activeFolderId != null &&
!context.isLoading
!context.isLoading &&
context.globalSearchQuery == null
) {
// Show a placeholder if only the root folder exists and no dataset is available yet
// (aka a new, empty organization)
Expand Down