Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate rare rendering bug #7163

Merged
merged 4 commits into from
Jun 26, 2023
Merged

Mitigate rare rendering bug #7163

merged 4 commits into from
Jun 26, 2023

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jun 20, 2023

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • import this DS via zarr streaming
  • zoom to mag 1,8,8 and verify that no rendering bug is visible anymore

(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Jun 20, 2023
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I'm wondering whether one could somehow deduce whether a smaller or larger subdivision is needed, based maybe on the scale? of the dataset or other parameters. We could investigate that if we ever notice that the larger subdivision has a performance impact.

@philippotto
Copy link
Member Author

+1

I'm wondering whether one could somehow deduce whether a smaller or larger subdivision is needed, based maybe on the scale? of the dataset or other parameters. We could investigate that if we ever notice that the larger subdivision has a performance impact.

Yes, I think, this is possible per se, but I'd rather invest time in making the rendering use multiple passes in the hope that this is a greater performance boost :)

@philippotto philippotto enabled auto-merge (squash) June 26, 2023 08:19
@philippotto philippotto merged commit a7da37a into master Jun 26, 2023
@philippotto philippotto deleted the increase-plane-subdivision branch June 26, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants