Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decompression of garbage data after valid gzip data causing decompression to fail #7119

Merged
merged 3 commits into from
Jun 5, 2023

Conversation

frcroth
Copy link
Member

@frcroth frcroth commented Jun 2, 2023

I am not sure if this breaks any other datasets (it fixes minnie65 with s3). The true parameter was introduced with #6466, I tested the only n5 dataset known to me and it worked.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Explore minnie65 via s3

Issues:


(Please delete unneeded items, merge only when none are left open)

  • Updated changelog
  • Needs datastore update after deployment

@frcroth frcroth requested a review from fm3 June 2, 2023 15:28
@frcroth frcroth self-assigned this Jun 2, 2023
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I tested a couple more datasets and they worked for me as well :)

@frcroth frcroth merged commit 13ff855 into master Jun 5, 2023
@frcroth frcroth deleted the fix-gzip-junk branch June 5, 2023 07:43
hotzenklotz added a commit that referenced this pull request Jun 8, 2023
…esign-right-sidebar

* 'master' of github.com:scalableminds/webknossos:
  Create bounding box by dragging with box tool (#7118)
  Prevent 'negative' buckets from being created (#7124)
  Lazy load onnx and canvas2html module (#7121)
  Disable editing of super voxel skeletons in skeleton mode (#7086)
  add missing evolution to migration guide (#7126)
  Change sttp backend to HttpURLConnectionBackend (#7125)
  Implement Zarr v3 and sharding codec (#7079)
  Fix decompression of garbage data after valid gzip data causing decompression to fail (#7119)
  When scanning volume buckets, skip those with unparseable key (#7115)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decompression of sharded mag1 precomputed dataset on s3 fails
2 participants