Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Min length for layer names is one #7064

Merged
merged 3 commits into from
May 11, 2023
Merged

Min length for layer names is one #7064

merged 3 commits into from
May 11, 2023

Conversation

dieknolle3333
Copy link
Contributor

@dieknolle3333 dieknolle3333 commented May 9, 2023 •
edited
Loading

Steps to test:

  • Go to dataset list view > Settings and change the dataset name in the form to less then 3 characters. There should be a form error.
  • In the same form, edit a layer name. You should be able to set a single character name.
  • Add a remote dataset. Repeat steps 1 and 2 in the second form (after clicking Add Layer).

Issues:

(Please delete unneeded items, merge only when none are left open)

@dieknolle3333 dieknolle3333 self-assigned this May 9, 2023
@dieknolle3333 dieknolle3333 marked this pull request as ready for review May 9, 2023 14:35
@philippotto
Copy link
Member

great! 👍

@fm3 do you know whether the back-end also has a check for this? At least, I'm vaguely remembering this..

Also I'm wondering whether we should soften the requirement for the dataset name, too 🤔 Any thoughts, @fm3?

@fm3
Copy link
Member

fm3 commented May 10, 2023 •
edited
Loading

The back-end does not check layer name lengths. It has a couple checks, including unique names, but layer name length is not among them.

As Norman stated in #7020 (comment), the dataset name restriction should stay in place.

philippotto
philippotto approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👍

Thanks for the clarifictions, @fm3 🙏

@philippotto philippotto enabled auto-merge (squash) May 11, 2023 16:15
@philippotto philippotto merged commit 50b525b into master May 11, 2023
@philippotto philippotto deleted the layer-name-length branch May 11, 2023 16:31
hotzenklotz added a commit that referenced this pull request May 17, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into emp…
790a5bf 
…ty-list-drawings

* 'master' of github.com:scalableminds/webknossos: (23 commits)
  fix scrolling in organization switcher in terms-of-services modal (#7083)
  Auto-Select via SAM (#7051)
  Build STL in chunks when exporting them (#7074)
  Improve performance for large (oversegmentation) meshes (#7077)
  Fix display of used storage in power plan (#7057)
  Fix user limits for invites (#7078)
  adds fileSize to voxelytics workflow list (#7071)
  Improve error logging for bucket requests (#7053)
  Fix zarr streaming datasource-properties.json generation for non-wkw/zarr datasets (#7065)
  Min length for layer names is one (#7064)
  Include voxelytics workflow name in tab title (#7070)
  Fix local to global layer index look up (#7066)
  Merge editable mappings (#7026)
  store correct artifacts for wkorg nightly (#7060)
  Team edit modal (#7043)
  Fix voxel offset in chunk name for unsharded neuroglancer precomputed datasets (#7062)
  Fix offset when loading non-aligned buckets for zarr/n5/precomputed (#7058)
  fixes wallTimes query for workflow reports (#7059)
  Handle Remote Dataset Edge Cases: compressed content-encoding, float voxel size (#7041)
  Release 23.05.2 (#7056)
  ...
hotzenklotz added a commit that referenced this pull request May 17, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into rem…
b5a788f 
…ove_wkconnect

* 'master' of github.com:scalableminds/webknossos: (33 commits)
  Fix bug in fallback rendering when layer has missing mags (#7082)
  Fix duplicate on volumes with no fallback layer (#7085)
  fix scrolling in organization switcher in terms-of-services modal (#7083)
  Auto-Select via SAM (#7051)
  Build STL in chunks when exporting them (#7074)
  Improve performance for large (oversegmentation) meshes (#7077)
  Fix display of used storage in power plan (#7057)
  Fix user limits for invites (#7078)
  adds fileSize to voxelytics workflow list (#7071)
  Improve error logging for bucket requests (#7053)
  Fix zarr streaming datasource-properties.json generation for non-wkw/zarr datasets (#7065)
  Min length for layer names is one (#7064)
  Include voxelytics workflow name in tab title (#7070)
  Fix local to global layer index look up (#7066)
  Merge editable mappings (#7026)
  store correct artifacts for wkorg nightly (#7060)
  Team edit modal (#7043)
  Fix voxel offset in chunk name for unsharded neuroglancer precomputed datasets (#7062)
  Fix offset when loading non-aligned buckets for zarr/n5/precomputed (#7058)
  fixes wallTimes query for workflow reports (#7059)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@dieknolle3333 dieknolle3333

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layer name length should not be restricted to minimum 3 characters
3 participants
@dieknolle3333 @philippotto @fm3