-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segment to Bucket Index for Volume Annotations #7063
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frcroth
reviewed
Jun 12, 2023
...pp/com/scalableminds/webknossos/tracingstore/tracings/volume/VolumeSegmentIndexService.scala
Outdated
Show resolved
Hide resolved
...app/com/scalableminds/webknossos/tracingstore/tracings/volume/VolumeSegmentIndexBuffer.scala
Outdated
Show resolved
Hide resolved
frcroth
reviewed
Jun 12, 2023
...pp/com/scalableminds/webknossos/tracingstore/tracings/volume/VolumeSegmentIndexService.scala
Show resolved
Hide resolved
frcroth
approved these changes
Jun 12, 2023
hotzenklotz
added a commit
that referenced
this pull request
Jun 14, 2023
…esign-right-sidebar * 'master' of github.com:scalableminds/webknossos: Layer actions overflow menu (#7123) Unify DatasetPath and VaultPath, cleaner ChunkReader creation (#7134) Segment to Bucket Index for Volume Annotations (#7063) Reverse compression on sharded neuroglancer datasets (#7135)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates an index structure for volume annotations. For every segment id, the list of buckets that contain this segment is stored. This is stored separately in the fossildb and updated on volume annotation mutation.
This lays the basis for new routes calculating properties of the segment volumes, e.g. the volume in voxels. A new route already provides that one. More complex metrics (surface area, sphericity, connected components) may be added later
TODO
Follow-up
Steps to test:
/tracings/volume/<tracingId>/segmentStatistics/volume?segmentId=1&mag=1&token=<token>
Issues: