Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with styling in dark mode on login page #7052

Merged
merged 2 commits into from
May 4, 2023

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented May 4, 2023

Fix issues with styling in dark mode on login page. Antd v4 does not explicitly set a background color for inputs in dark mode (background: transparent) but always expects a dark underground.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Switch OS / browser to dark mode
  • Go to login / register page
  • Enter email wrong
  • You should see white text on black background even if the input component is highlighted because of an error (invalid email)

Issues:


(Please delete unneeded items, merge only when none are left open)

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me 👍

@hotzenklotz hotzenklotz merged commit 802cf84 into master May 4, 2023
@hotzenklotz hotzenklotz deleted the dark-login-fix branch May 4, 2023 12:54
hotzenklotz added a commit that referenced this pull request May 17, 2023
…ty-list-drawings

* 'master' of github.com:scalableminds/webknossos: (25 commits)
  Fix issues with styling in dark mode on login page (#7052)
  Fix nightly by setting missing token (#7048)
  Release 23.05.1 (#7042)
  DRY types in update_actions.ts (#7036)
  Remove some spammy logging from backend (#7039)
  Use zarr string fill values (#7017)
  Fix voxel offset for Neuroglancer Precomputed datasets (#7019)
  Log when user is activated (#7027)
  Fix exception in applying UpdateTreeGroupVisibility skeleton action (#7037)
  Fix organization storage layouting (#7034)
  Update docker compose commands + dev install readme (#7002)
  Add segment groups (#6966)
  Add screenshot nightly test for wkorg (#7030)
  Workaround for WebGL crash for datasets with many segmentation layers (#6995)
  Fix download of public annotation, include access ctx in user cache key (#7025)
  Fix that changing a segment color could lead to a crash (#7000)
  Add more error chaining to annotation download (#7023)
  Guard against NaNs in shader (#7018)
  Store editable mappings in multiple fossildb columns+keys (#6903)
  Context action to move tree to group (#7005)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error case renders login form field unreadable in darkmode
2 participants