-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only reload affected areas when proofreading #7050
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very elegant solution! 🤩
I didn't encounter any issues during testing. I found it hard to assess how much of the latency is due to the added containment check - did you measure this somehow? In any case, I think it's definitely worth it to avoid reloading all the data! Much better UX.
Yes, I measured this (forgot to include it in the PR description). It takes about 1ms to compute the |
Rough measurements show that ~80% of bucket reloads can be avoided that way for an average proofread operation.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)