Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only reload affected areas when proofreading #7050

Merged
merged 8 commits into from
May 4, 2023
Merged

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented May 4, 2023

Rough measurements show that ~80% of bucket reloads can be avoided that way for an average proofread operation.

URL of deployed dev instance (used for testing):

Steps to test:

  • open l4dense_motta_et_al_dev_v2
  • select mapping 80
  • do proofreading with
    • merge and split (without skeletons)
    • load agglomerate skeletons and split/merge/min-cut these
  • only the affected areas should reload

Issues:


(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this May 4, 2023
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very elegant solution! 🤩

I didn't encounter any issues during testing. I found it hard to assess how much of the latency is due to the added containment check - did you measure this somehow? In any case, I think it's definitely worth it to avoid reloading all the data! Much better UX.

@philippotto
Copy link
Member Author

did you measure this somehow?

Yes, I measured this (forgot to include it in the PR description). It takes about 1ms to compute the Set, which seems like a very good investment to me :)

@philippotto philippotto enabled auto-merge (squash) May 4, 2023 17:49
@philippotto philippotto merged commit 3a3795a into master May 4, 2023
@philippotto philippotto deleted the smart-reload branch May 4, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

During Proofreading, only reload "affected" buckets after split/merge
3 participants