-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow batch reading of mesh chunks #7001
Conversation
@philippotto Backend should be ready (though not completely tested) |
webknossos-datastore/app/com/scalableminds/webknossos/datastore/services/MeshFileService.scala
Outdated
Show resolved
Hide resolved
I just noticed that The front-end doesn't handle this correctly currently (the spinner just keeps spinning). I'll add proper error handling and then we should be able to debug this further. |
I think, the PR is ready for review. @daniel-wer It can make sense to review the PR by commit range (I did some refactoring of the isosurface saga were I simply extracted/moved some code). Also, I upgraded the draco libs. @frcroth @fm3 See my previous comment regarding an error where a mesh chunk cannot be decoded. I added better error handling and reporting, but I couldn't really figure out what's happening. I only found one segment where one mesh request fails and that is:
It happens with Maybe you have an idea what could be causing this. However, I think, it's not blocking this PR as this is already an issue on master. |
Bug can be seen isolated on this dev instance: https://provokemeshdecodingerror.webknossos.xyz/datasets/sample_organization/l4dense_motta_et_al_dev_v2/view#2816,4353,1792,0,1.3 (enable mapping 80 and load a mesh). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me :) Great speed increase! I added a note on parallelization.
@philippotto could you write an issue for the draco decoding problem?
webknossos-datastore/app/com/scalableminds/webknossos/datastore/services/MeshFileService.scala
Outdated
Show resolved
Hide resolved
webknossos-datastore/app/com/scalableminds/webknossos/datastore/services/MeshFileService.scala
Outdated
Show resolved
Hide resolved
webknossos-datastore/app/com/scalableminds/webknossos/datastore/services/MeshFileService.scala
Outdated
Show resolved
Hide resolved
Done! #7044 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works very well, awesome speed boost!
webknossos-datastore/app/com/scalableminds/webknossos/datastore/services/MeshFileService.scala
Show resolved
Hide resolved
@frcroth just a small ping in case this PR slipped through your inbox :) |
@philippotto I'm a bit out of the loop on this one. What should I do? |
Only the PR feedback was missing, but I guess this is good now 👍 @fm3 Do you want to leave a final approval? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Boom 🚀
URL of deployed dev instance (used for testing):
Steps to test:
TODO
[ ] Use uint32 instead of uint64 for jump table so that Uint32Array can be used in JSIssues:
(Please delete unneeded items, merge only when none are left open)