Fix incorrect rotation matrix after selecting nodes #6978
Conversation
…nodes that were created in arbitrary mode
|
I followed the testing instructions and the issue still occured 🤔
Edit: The issue actually already occurs when switching back to orthogonal, no node selection needed. Maybe, the additional condition prevents the rotation reset that's triggered when switching to orthogonal? |
…tching to ortho mode
…nossos into fix-changing-rotation
Argh, I think I had "prepared" nodes with rotations and after building the fix I only ensured that selecting these nodes didn't cause rendering bugs.
Yes, that was exactly it. Thanks for catching this 🙏 🙏 🙏 Could you have another look for a final thumbs up? |
* fix that rotation could be changed in orthogonal mode when selecting nodes that were created in arbitrary mode * fix spec * update changelog * Update frontend/javascripts/oxalis/model/reducers/flycam_reducer.ts * fix regression which prevented the flycam matrix to be reset when switching to ortho mode
* Fix missing buckets when annotation has set rotation value (#6967) * don't use stored rotation from annotation when mode is set to orthogonal * update changelog * Update frontend/javascripts/oxalis/model_initialization.ts * read viewMode from store instead of from url state --------- Co-authored-by: Daniel <[email protected]> * Release 23.04.1 * Fix incorrect rotation matrix after selecting nodes (#6978) * fix that rotation could be changed in orthogonal mode when selecting nodes that were created in arbitrary mode * fix spec * update changelog * Update frontend/javascripts/oxalis/model/reducers/flycam_reducer.ts * fix regression which prevented the flycam matrix to be reset when switching to ortho mode * Release 23.04.2 --------- Co-authored-by: Daniel <[email protected]>
Nodes that are created in arbitrary mode have an attached non-default rotation. Selecting that node will center their position and change apply their rotation. In orthogonal mode, this shouldn't happen as that rotation is used for bucket picking.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)