-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolate meshes by layer and remove old mesh-storage code #6960
Conversation
… wk and would be stored on the server at some point)
The last post in the issue stated that we might want to reconsider if we really want to remove that feature (?) Either way, I’d defer removing the backend code in order not to block this PR until I have time. But I will gladly do so in a follow-up PR |
Yes, but I'd put the emphasis on "might" 🙈 The last feedback we got on that topic was over a year ago (and in total it was by one user). The feature was already effectively removed, anyway, and I don't really see big reasons to reintroduce it. For the mentioned use case, one could also find other ways (e.g., create a volume annotation to get the desired shape as an isosurface or allow to create a plane with a skeleton).
Ok, cool 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this bug fixing & refactoring 🥇 🦖 .
I only left some small suggestions (renaming & moving a method into another class). As they are not much work / shouldn't be risky changes I already gave you an approve :) I hope that's alrighty.
I did not check, whether you removed every single method that is not needed anymore is removed. I hope that's ok. If you want me to also check this, just ping me :).
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)