Remove segment from list and add undo/redo for segments #6944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippotto
changed the title
daniel-wer
reviewed
Mar 28, 2023
There was a problem hiding this comment.
Code looks very good to me 👍
- During testing I encountered some inconsistent behavior related to branching off from an earlier undo state. In that case the undo stack doesn't seem to be correctly pruned and one version of the old branch remains on the stack instead of the version that was branched from. See this gif, but let me know if you can't follow what's happening:
- When removing a segment from the list which had an ad-hoc or precomputed mesh loaded and then undoing that, the mesh check mark is restored but the mesh is not. Maybe the mesh loading can be retriggered in that case? Otherwise, the check mark shouldn't be checked.
- [Low-Pri] Unrelated to this PR, but maybe it's quick to fix. The cross hair and brush icon next to the segment ID are in italics as well, looking slightly weird.
…eUndoBuckets constraint
|
Thanks for your review & testing! I fixed the issues you found and also refactored the code a bit which is why I would recommend to review the changes commit-by-commit (one of them just extracts a large chunk of code into a new module). I hope the comments are self-explanatory, otherwise, let me know! Took me quite a bit of diving today to get into the save saga again 🤿 |
daniel-wer
reviewed
Mar 30, 2023
…t were caused by direct actions of the user create new undo states
daniel-wer
approved these changes
Apr 3, 2023
hotzenklotz
added a commit
that referenced
this pull request
Apr 4, 2023
…wings * 'master' of github.com:scalableminds/webknossos: updates docs for docker installation (#6963) Fix misc stuff when viewing tasks/annotations of another user (#6957) Remove segment from list and add undo/redo for segments (#6944) Log all details on deleting annotation layer (#6950) fix typo Rename demo instance to wkorg instance (#6941) Add LOD mesh support for frontend (#6909) Fix layout of view mode switcher and move it (#6949) VaultPath no longer extends nio.Path (#6942) Release 23.04.0 (#6945) Use new zip.js version to allow zip64 uploads (#6939) Implement viewing sharded neuroglancer precomputed datasets (#6920) Reject dataset uploads if organization storage quota is exceeded (#6893) Refactor deprecated antd Dropdown menus (#6898)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… removing a segment.
Also, I renamed a bunch of
cellIdvars tosegmentIdto unify this mismatch a bit. For reviewing, it might be better to review that commit isolated.URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)