Send Cache-Control: no-cache for most routes #6937
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Cache-Control: no-cache
header to most routes.Routes that go via the box-to-result codepath get it there.
Routes that don’t do that now have an explicit
addNoCacheHeaderFallback
wrapper.Asset routes are not affected, neither are routes that already set the Cache-Control header in their implementation (e.g. thumbnail route)
Note that routes rejected by silhouette with 401 unauthenticated will not have the header set. But I assume no reasonable browser caches 401 responses anyway.
URL of deployed dev instance (used for testing):
Steps to test:
Issues: