Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix date formatting for VX reports #6908

Merged
merged 3 commits into from
Mar 9, 2023
Merged

Fix date formatting for VX reports #6908

merged 3 commits into from
Mar 9, 2023

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Mar 9, 2023 •
edited
Loading

This PR fixes date formatting for VX reports. I believe we need to add the "localized format plugin" to dayjs in order to use days().format("lll"). See dayjs docs on this: https://day.js.org/docs/en/display/format#localized-formats

Before:
image
image

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Open any VX report
  • Check that the start date under the workflow title is shown as a well formatted string and not just lll
  • How over the runtime of any task in the list to bring up the tooltip with more information. That should also be fixed.

Issues:

(Please delete unneeded items, merge only when none are left open)

@hotzenklotz hotzenklotz self-assigned this Mar 9, 2023
@hotzenklotz hotzenklotz requested a review from fm3 March 9, 2023 12:46
@hotzenklotz
updated changelog
4ba3b96
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into loc…
f9f10db 
…alized_format

* 'master' of github.com:scalableminds/webknossos:
  Fix rare crash when viewing shared annotation (#6892)
fm3
fm3 approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@hotzenklotz hotzenklotz enabled auto-merge (squash) March 9, 2023 13:04
@hotzenklotz hotzenklotz merged commit be44b11 into master Mar 9, 2023
@hotzenklotz hotzenklotz deleted the localized_format branch March 9, 2023 13:06
hotzenklotz added a commit that referenced this pull request Mar 13, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into dro…
17bcd86 
…pdown-menu

* 'master' of github.com:scalableminds/webknossos:
  Avoid SQL error when fetching view config for zero-layer dataset (#6912)
  Fix date formatting for VX reports (#6908)
  Fix rare crash when viewing shared annotation (#6892)
  Slim down view mode dropdown by using icons (#6900)
  Logging on password reset/change (#6901)
  When merging volume tracings, also merge segment lists (#6882)
  avoid spinner when switching tabs in dashboard (#6894)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

Assignees

@hotzenklotz hotzenklotz

Labels
bug frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hotzenklotz @fm3