Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement http range requests for HttpsSeekableByteChannel #6869

Merged
merged 15 commits into from
Mar 2, 2023

Conversation

frcroth
Copy link
Member

@frcroth frcroth commented Feb 22, 2023

URL of deployed dev instance (used for testing):

Steps to test:

  • View a remote dataset via HTTPS
  • View a remote dataset via HTTPS with basic auth
  • Run tests that actually use HTTPS range requests

Issues:


(Please delete unneeded items, merge only when none are left open)

  • I think no changelog since this is not user facing?
  • Considered common edge cases
  • Needs datastore update after deployment

@frcroth frcroth changed the title WIP: Implement http range requests for HttpsSeekableByteChannel Implement http range requests for HttpsSeekableByteChannel Feb 23, 2023
@frcroth frcroth requested a review from fm3 February 23, 2023 11:08
@frcroth frcroth marked this pull request as ready for review February 23, 2023 11:08
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Could you add an entry to the migration guide, mentioning that java 8 is no longer supported?
The wk code does not currently use the range requests, right? So the steps to test is just to ensure that the read fully codepath still works?

@frcroth frcroth requested a review from fm3 February 28, 2023 10:44
@frcroth frcroth merged commit 4e672e0 into master Mar 2, 2023
@frcroth frcroth deleted the http-range-requests branch March 2, 2023 08:34
hotzenklotz added a commit that referenced this pull request Mar 3, 2023
…d-v4.24

* 'master' of github.com:scalableminds/webknossos:
  Implement http range requests for HttpsSeekableByteChannel (#6869)
  new GH action for adding issues to project board
  Fix links in Changelog (#6881)
  adds dedicated explore method for zarr datasets with a datasource-properties.json (#6879)
  Release 23.03.0 (#6880)
  Fix superUser being wrongly marked as organization owners (#6876)
  Followups for OME-TIFF export (#6874)
  Fix reload-precomputed-mesh functionality (#6875)
  Adds OME-TIFF export (#6838)
  Add evolutions 99,100 to migration guide (#6871)
  Add link to imprint and privacy to help menu (#6870)
  Annotation Locking Mechanism (#6819)
hotzenklotz added a commit that referenced this pull request Mar 6, 2023
…come_header_UI

* 'master' of github.com:scalableminds/webknossos: (34 commits)
  Slim down view mode dropdown by using icons (#6900)
  Logging on password reset/change (#6901)
  When merging volume tracings, also merge segment lists (#6882)
  avoid spinner when switching tabs in dashboard (#6894)
  Upgrade Antd to v4.24 (#6865)
  Support n5 end-chunks with chunksize differing from metadata chunksize (#6890)
  Implement http range requests for HttpsSeekableByteChannel (#6869)
  new GH action for adding issues to project board
  Fix links in Changelog (#6881)
  adds dedicated explore method for zarr datasets with a datasource-properties.json (#6879)
  Release 23.03.0 (#6880)
  Fix superUser being wrongly marked as organization owners (#6876)
  Followups for OME-TIFF export (#6874)
  Fix reload-precomputed-mesh functionality (#6875)
  Adds OME-TIFF export (#6838)
  Add evolutions 99,100 to migration guide (#6871)
  Add link to imprint and privacy to help menu (#6870)
  Annotation Locking Mechanism (#6819)
  Update deprecated antd <Menu> (#6860)
  Add functions to get and set segment colors to the frontend API (#6853)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants