Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent merging/splitting with segment 0 #6793

Merged
merged 4 commits into from
Jan 31, 2023
Merged

Prevent merging/splitting with segment 0 #6793

merged 4 commits into from
Jan 31, 2023

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jan 31, 2023 •
edited by daniel-wer
Loading

URL of deployed dev instance (used for testing):

Steps to test:

  • create an annotation for the test-agglomerate-file DS
  • select the proofreading tool
  • ensure that segment 0 cannot be selected (worked before, too)
  • activate a segment
  • try to merge/split with/from segment 0
  • a warning toast should appear and nothing should happen
  • save and reload -> should still be valid

Issues:

(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Jan 31, 2023
daniel-wer
daniel-wer approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you for fixing this 👍

@philippotto philippotto enabled auto-merge (squash) January 31, 2023 12:34
@philippotto philippotto merged commit aa69f67 into master Jan 31, 2023
@philippotto philippotto deleted the prevent-0-merge branch January 31, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippotto @daniel-wer