Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exploring remote datasets with no credentials #6764

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jan 19, 2023

Fox.successful(None) encodes that the result is valid, but does not contain credentials. Fox.empty stopped the calling function’s for comprehension.

Also cleaned up some magic strings.

URL of deployed dev instance (used for testing):

Steps to test:

  • Try exploring remote dataset with and without credentials

@fm3 fm3 requested a review from frcroth January 19, 2023 12:53
@fm3 fm3 self-assigned this Jan 19, 2023
@fm3 fm3 merged commit 7679928 into master Jan 19, 2023
@fm3 fm3 deleted the explore-remote-fix-anonymous branch January 19, 2023 13:41
hotzenklotz added a commit that referenced this pull request Jan 19, 2023
…orce_plan

* 'master' of github.com:scalableminds/webknossos:
  Fix antd deprecation warning for <Modal open/visible> (#6765)
  Fix exploring remote datasets with no credentials (#6764)
bulldozer-boy bot pushed a commit that referenced this pull request Jan 23, 2023
* enforce pricing plan for features (WIP)
* enforce pricing for navbar links
* Merge branch 'master' of github.com:scalableminds/webknossos into enforce_plan

* 'master' of github.com:scalableminds/webknossos:
  Update VoxelyticsDAO.scala
  Show voxel size in details sidebar in new datasets tab (#6755)
  Fix font import (#6754)
  Fix breadcrumbs (II) (#6753)
* add organization to store
* fix type errors for activeOrganization
* Merge branch 'master' of github.com:scalableminds/webknossos into enforce_plan

* 'master' of github.com:scalableminds/webknossos:
  Make voxelytics sql queries compatible with postgres 10 (#6763)
  Adapt viewport and crosshair colors to new color scheme (#6760)
  minor logo fix (#6762)
  Fix superuser organization switching (#6756)
* naming stuff is hard
* Merge branch 'master' of github.com:scalableminds/webknossos into enforce_plan
* 'master' of github.com:scalableminds/webknossos:
  Fix antd deprecation warning for <Modal open/visible> (#6765)
  Fix exploring remote datasets with no credentials (#6764)
* added new page for when features are not available due to pricing limits
* prevent folder creation on dashboard
* Merge branch 'master' into enforce_plan
* applied PR feedback
* applied even more PR feedback
* Update frontend/javascripts/components/pricing_enforcers.tsx

Co-authored-by: Philipp Otto <[email protected]>
* Update frontend/javascripts/components/pricing_enforcers.tsx

Co-authored-by: Philipp Otto <[email protected]>
* Merge branch 'master' into enforce_plan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants