Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle failing breadcrumb generation #6750

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Gracefully handle failing breadcrumb generation #6750

merged 3 commits into from
Jan 17, 2023

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jan 17, 2023 •
edited
Loading

Also: don't show breadcrubs in non-search view

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • open folder view
  • check that breadcrumbs are not rendered (instead, the datastore is rendered now; should I remove this in the folders tab?)
  • search for a dataset --> breadcrumbs should be rendered

Issues:

(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Jan 17, 2023
@philippotto philippotto marked this pull request as ready for review January 17, 2023 11:00
@bulldozer-boy bulldozer-boy bot merged commit 527d258 into master Jan 17, 2023
@bulldozer-boy bulldozer-boy bot deleted the fix-breadcrumbs branch January 17, 2023 13:05
philippotto added a commit that referenced this pull request Jan 17, 2023
@philippotto
Revert "Gracefully handle failing breadcrumb generation (#6750)"
f40cd8e 
This reverts commit 527d258.
@philippotto philippotto mentioned this pull request Jan 17, 2023
Merged
2 tasks
philippotto added a commit that referenced this pull request Jan 17, 2023
@philippotto
Fix breadcrumbs (II) (#6753)
7d2e9a3 
* Revert "Gracefully handle failing breadcrumb generation (#6750)"

This reverts commit 527d258.

* revert conversion to Map as this breaks with react-query serialization; instead add minimal fix for broken breadcrumbs

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normanrz normanrz normanrz approved these changes

Assignees

@philippotto philippotto

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippotto @normanrz