Use less ram when initializing data textures #6711
Conversation
…rows probably benign error, though)
…ead of using templating" This reverts commit c20ad3f.
…ing issue on Mi 8)
There was a problem hiding this comment.
As far as I can see, everything still works.
When I switch to flight mode for the first time, I get a WebGL warning [.WebGL-0xcdc0032ea00] GL_INVALID_VALUE: Texture dimensions must all be greater than zero. which is one less than on master (where there is also [.WebGL-0xcdc050ba900] GL_INVALID_OPERATION: Level of detail outside of range.), so that's good I suppose 😁
Your call whether it makes sense to execute the screenshot tests for this branch to make sure everything still renders as usual (since you can better assess what changed in this PR).
Edit: Also a final test on an iphone whether this still fixes the RAM initialization issue would be good :)
This reverts commit 3470d5d.
This was a good call 👍 The nightly showed that the skeletons were broken, because a normal THREE.DataTexture was used for that 🙈 I adapted the workaround so, that only gl calls are noop'ed if an empty TypedArray is passed. I think, this should be way more robust. The last nightly still failed, but this is because the connectome tab is not enabled for the particular dev instance. I tested that case manually and it worked. Please have a final look at my last changes and then I'd merge this PR 🤞 |
…cing * 'master' of github.com:scalableminds/webknossos: Replace babel with esbuild for tests and for webpack (#6527) Use less ram when initializing data textures (#6711) Composable sql interpolation (#6718) Release 23.01.0 (#6717) add license checker (#6715) Fix brush performance for coarse mags & avoid some unnecessary re-renders (#6708) Change backend format command (#6697) Improve layout of terms of services check (#6712)
See code comments.
URL of deployed dev instance (used for testing):
Steps to test:
window.testContextLoss()in the console and check that wk is usable again after a few seconds of flickeringIssues:
(Please delete unneeded items, merge only when none are left open)