-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash in publication page and add error boundaries #6700
Conversation
…rashes in the navbar)
…e datasets or annotations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review will be easier by ignoring whitespace changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good. i'll do some testing now
Tested -> works. I was wondering if the toast is still required? Seems a bit redundant. |
I assume you tested it locally, right? Orthogonal to the error boundaries, there is a global |
Co-authored-by: Norman Rzepka <[email protected]>
…ossos into fix-publication-page
…cing * 'master' of github.com:scalableminds/webknossos: Automatically open (and close) quick select settings when labeling in… (#6706) Add Terms of Service Acceptance Concept (#6632) Fix crash in publication page and add error boundaries (#6700) temporarily disable vx related polling (#6702) add protected and private modifiers to DAO hierarchy (#6698)
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)