Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve miscellaneous things in Folders tab #6674

Merged
merged 12 commits into from
Dec 2, 2022

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Dec 1, 2022

Quoting from #6669

Bugs:

  • switching to another orga causes error-toast to appear because folder id from url is loaded
  • dragged row has full opacity on some browsers / OS ? makes it hard to see where it's being dropped over. use setDragImage to generate a small drag image so that the wide row doesn't block other elements anymore.
  • right sidebar doesn't mention limiting of search results when stating total amount (should do the same as the headline)
  • cancelling new-folder input still creates folder
  • using context menu on not-selected folder should not select it
  • deleting active folder should select another folder

Improvements:

  • clearer display of "default" permissions (tag can be confused with actual team)

URL of deployed dev instance (used for testing):

Steps to test:

  • I tested all of the described things. I think, there's no need to test the time-consuming things again (e.g., orga switching or search result limit). However, the other things, such as dragging a dataset should be easy to test :)

Issues:


(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Dec 1, 2022
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, everything works as described, LGTM 👍

Great improvement for the drag preview, in particular!

@philippotto philippotto merged commit b4fd67a into master Dec 2, 2022
@philippotto philippotto deleted the folders-follow-up branch December 2, 2022 09:27
hotzenklotz added a commit that referenced this pull request Dec 6, 2022
…cing

* 'master' of github.com:scalableminds/webknossos: (23 commits)
  Guard against invalid-mag bucket volume save actions (#6660)
  Add OIDC authentication (#6534)
  Add second (non-admin) default user to "initial data" trigger (#6666)
  Fix and improve miscellaneous things in Folders tab (#6674)
  Improves mag and voxelSize inferral for remote datasets (#6670)
  Squashed commit of the following:
  Fix import of N5 datasets by adding n5 schema to frontend validation (#6668)
  Virtual Folder Structure for Datasets (#6591)
  Ability to recover from webGL context loss (#6663)
  Fix assertion that referenced teams cannot be deleted (#6664)
  fix task summary with pending jobs (#6662)
  Only allow taskTypeId as parameter in task creation (#6640)
  Release 22.12.0 (#6661)
  Create Annotation From View Mode: Keep Activated Mapping (#6647)
  Workaround to avoid false-positive version warning (#6656)
  Fix WK-lib download snippet (#6605)
  Use LZ4 with WASM for volume saving/undo/redo (#6652)
  Fix version number extraction when building docker image (#6655)
  Pass mapping name to precompute meshes (#6651)
  Deduplicate bboxes when importing NML (#6648)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants