-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Help button #6560
Added Help button #6560
Conversation
…p_button * 'master' of github.com:scalableminds/webknossos: Reload histogram when reloading layer (#6537)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend LGTM :)
Two questions:
- Should the user maybe get a slightly different email along the lines of “we received the following feedback message and will get back to you soon”?
- Should this always be active? Or just for the webknossos.org instance?
I don't think that it makes much of a difference. The email copy for the user serves primarily to give him some feedback that his request/question was entered into the system. It also nicely ties together the conversation, when we answer directly to that email.
Yes, I think it should be available for all instances. It does not hurt if we get questions from the open-source instances or dedicated hosted ones. If we get to too many questions (doubtful) then we can always be more selective with this feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this crashes when being logged out, so i couldn't test the actual UX yet 🙈
Co-authored-by: Philipp Otto <[email protected]>
@philippotto The logged-out crash should be fixed. Thanks for spotting that. |
if (!activeUser) return null; | ||
if (activeUser && activeUser.novelUserExperienceInfos.hasDiscardedHelpButton) return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should logged-out users see the help button and be able to send emails? we won't know their email to reply though, right? if we support this somehow, the close-button should be hidden, though, since it doesn't do anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logged out users should not see the help button:
- We don't have an email to respond to
- there is not much you can do in logged out state anyway. you likely be browsing the landing page
2.1 alternatively, you can be logged out for viewing a public dataset/annotation. That is a read-only interaction anyway and would not expect someone to ask questions
}; | ||
|
||
if (!activeUser) return null; | ||
if (activeUser && activeUser.novelUserExperienceInfos.hasDiscardedHelpButton) return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (activeUser && activeUser.novelUserExperienceInfos.hasDiscardedHelpButton) return null; | |
if (activeUser.novelUserExperienceInfos.hasDiscardedHelpButton) return null; |
since you are already checking for !activeUser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me 👍 let's see how often this is used. on a big screen, the help button is rather low-key, but that's better than being too offensive, I guess.
The PR adds a small help button to the UI. Users can send us a question or give feedback.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)