Added manual task assignment #6551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssos into assign_task * 'assign-task-to-user' of github.com:scalableminds/webknossos: Allow assigning task to a user directly
2 tasks
|
@fm3 If I see this correctly, then manual task assignment returns a task object with negative finished instance:
|
hotzenklotz
changed the title
|
@daniel-wer Please have a look at the frontend parts for the PR review :-) |
Good catch! The old state was still partially used when writing the statistics json. I just pushed a fix |
jstriebel
reviewed
Oct 17, 2022
|
|
||
| val annotationId = ObjectId.generate | ||
| val now = new java.sql.Timestamp(System.currentTimeMillis) |
There was a problem hiding this comment.
If the related column is of type timestamp, we might directly use NOW() or LOCALTIMESTAMP() or sth similar, but probably doesn't matter with those queries.
jstriebel
approved these changes
Oct 17, 2022
|
auto-merge shot too fast here, I think this still needs a frontend-review @daniel-wer. Should we revert, or simply do the review-changes separately if there are any? |
daniel-wer
reviewed
Oct 17, 2022
| /> | ||
| </div> | ||
| <Alert | ||
| message="Note, manual assignments will bypass the automated task distribution system and its checks for user experience, access rights and other elligibility criteria." |
There was a problem hiding this comment.
I cannot propose code changes, because the PR was merged already, but it should be eligibility
hotzenklotz
added a commit
that referenced
this pull request
Oct 18, 2022
…ebar_button * 'master' of github.com:scalableminds/webknossos: added more usage shortcuts to status bar (#6549) Look up annotation dataset by tracing id instead of (broken) organizationName field (#6548) Add links to resource creation pages (#6513) Improve Zarr Import UI (and general editing of datasets) (#6485) Remove unused dataSetName and organizationName property of protobuf objects (#6559) WIP: Added manual task assignment (#6551) Fix zarr private links for volume tracings and some minor improvements to private links UI (#6541) Fix stack overflow in compactMovedNodesAndEdges (#6557)
hotzenklotz
added a commit
that referenced
this pull request
Oct 18, 2022
…ect_spinner * 'master' of github.com:scalableminds/webknossos: added more usage shortcuts to status bar (#6549) Look up annotation dataset by tracing id instead of (broken) organizationName field (#6548) Add links to resource creation pages (#6513) Improve Zarr Import UI (and general editing of datasets) (#6485) Remove unused dataSetName and organizationName property of protobuf objects (#6559) WIP: Added manual task assignment (#6551) Fix zarr private links for volume tracings and some minor improvements to private links UI (#6541) Fix stack overflow in compactMovedNodesAndEdges (#6557)
hotzenklotz
added a commit
that referenced
this pull request
Oct 19, 2022
…ault_volume_layer * 'master' of github.com:scalableminds/webknossos: (21 commits) adds ETA calculation to voxelytics tasks (#6564) update immutability-helper package to v3.1.1 with TS support (#6565) [Skeletons] Allow deletion of root group (#6553) fix disappearing sidebar button (#6555) Enable "What's new" in navbar for everybody (#6563) Highlight Menu in Navbar Menu (#6558) refactor Select loading spinner property (#6556) Reload histogram when reloading layer (#6537) added more usage shortcuts to status bar (#6549) Look up annotation dataset by tracing id instead of (broken) organizationName field (#6548) Add links to resource creation pages (#6513) Improve Zarr Import UI (and general editing of datasets) (#6485) Remove unused dataSetName and organizationName property of protobuf objects (#6559) WIP: Added manual task assignment (#6551) Fix zarr private links for volume tracings and some minor improvements to private links UI (#6541) Fix stack overflow in compactMovedNodesAndEdges (#6557) Add backspace keyboard shortcut to delete active node (#6554) fix scaling in new meshfile rendering (#6552) Added more filters and sorting options to Projects list (#6550) fix double occurance of "ago" in VX progress times (#6535) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now task can only be assigned through the automated task distribution system. This PR adds an additional way for manually assigning tasks to user through the admin interface/task list.
URL of deployed dev instance (used for testing):
Steps to test:
Issues: