Mag information is not lost on empty volumes #6481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frcroth
changed the title
fm3
approved these changes
Sep 22, 2022
CHANGELOG.unreleased.md
Outdated
| @@ -22,6 +22,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released | |||
| - Selecting a node with the proofreading tool won't have any side effects anymore. Previous versions could load additional agglomerate skeletons in certain scenarios which could be confusing. [#6477](https://github.com/scalableminds/webknossos/pull/6477) | |||
| - Sharing links are shortened by default. Within the sharing modal, this shortening behavior can be disabled. [#6461](https://github.com/scalableminds/webknossos/pull/6461) | |||
| - Removed optional "resolution" parameter from /datasets/:organizationName/:dataSetName/layers/:dataLayerName/data route. Use mag instead. [#6479](https://github.com/scalableminds/webknossos/pull/6479) | |||
| - Changed how volumes containing no data are stored. Now the selection of magnitudes is correctly exported and imported. [#6481](https://github.com/scalableminds/webknossos/pull/6481) | |||
There was a problem hiding this comment.
Suggested change
| - Changed how volumes containing no data are stored. Now the selection of magnitudes is correctly exported and imported. [#6481](https://github.com/scalableminds/webknossos/pull/6481) | |
| - Changed how volumes containing no data are stored. Now the selection of magnifications is correctly exported and imported. [#6481](https://github.com/scalableminds/webknossos/pull/6481) |
| import com.scalableminds.webknossos.wrap.{BlockType, WKWFile, WKWHeader} | ||
|
|
||
| import scala.collection.mutable | ||
| import scala.concurrent.Future | ||
|
|
||
| class WKWBucketStreamSink(val layer: DataLayer) extends WKWDataFormatHelper { | ||
|
|
||
| def apply(bucketStream: Iterator[(BucketPosition, Array[Byte])]): Iterator[NamedStream] = { | ||
| def apply(bucketStream: Iterator[(BucketPosition, Array[Byte])], mags: Seq[Vec3IntProto]): Iterator[NamedStream] = { |
There was a problem hiding this comment.
I’d suggest passing a Vec3Int in here, (not the proto version). The proto version does not have all the nice convenience methods we use all around the scala code. You can have the caller extend the ProtoGeometryImplicits trait, which should make vec3IntFromProto available (and since it is implicit, you might not even have to call it if the function signatures make the types unambiguous)
fm3
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
The original handling is still largely there to handle previously exported files.
(Please delete unneeded items, merge only when none are left open)