Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Proofreading: Add clear button for auxiliary skeletons/meshes & provide merge/split via context menu on voxel #6459

Merged
merged 6 commits into from
Sep 14, 2022

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Sep 12, 2022

Also see #6464 which is also contained in this PR.

image

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • open dataset with agglomerate mapping and activate that
  • use proof reading tool to load some skeletons and meshes
  • use clear button to remove the loaded skeletons and meshes

Issues:


(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Sep 12, 2022
@philippotto philippotto marked this pull request as ready for review September 12, 2022 14:49
…#6464)

* implement splitting and merging in proofreading via context menu on non-node position

* parallelize some async operations

* also validate unmapped ids when doing node-less split; refactor; don't center active node when reloading skeleton

* also expose min-cut in context menu when no node is clicked

* also remove trees when cleaning up that were added due to reloads

* clean up a bit

* update changelog

* keep currently active node despite of reloading the agglomerate skeleton after split/cut

* improve wording in connectome tab

* remove the split-only option from the context menu (when not rightclicking a node)

* update changelog

* Update frontend/javascripts/oxalis/model/sagas/proofread_saga.ts

Co-authored-by: Tom Herold <[email protected]>

* remove unnecessary log

* fix data loading route when floating positions are used

* only show proofreading tool if an agglomerate mapping is selected; don't show merge/min-cut context menu items if proofreading tool is not even shown

* fix ts error

* pretty

Co-authored-by: Tom Herold <[email protected]>
@philippotto philippotto changed the title Add clear button to toolbar to delete auxiliary skeletons and meshes Improve Proofreading: Add clear button for auxiliary skeletons/meshes & provide merge/split via context menu on voxel Sep 14, 2022
@philippotto philippotto enabled auto-merge (squash) September 14, 2022 12:57
@philippotto philippotto merged commit c944273 into master Sep 14, 2022
@philippotto philippotto deleted the proofreading-qol branch September 14, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Super Voxel Editing] Reset skeletons/meshes after successful mergers/split
2 participants