Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate route for Editable Mapping annotations #6446

Merged
merged 5 commits into from
Sep 12, 2022
Merged

Fix duplicate route for Editable Mapping annotations #6446

merged 5 commits into from
Sep 12, 2022

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Sep 2, 2022 •
edited
Loading

  • Include baseMappingName in the editable mapping info json so that it can be shown by the frontend
  • Fix “duplicate”/“copy to my account” for annotations with an editable mapping volume layer

URL of deployed dev instance (used for testing):

Steps to test:

  • Edit a mapping, select duplicate from menu
  • Duplicated annotation should show the same edited state of the mapping, subsequent edits of the two annotations should not interfere with each other.

Issues:

@fm3 fm3 self-assigned this Sep 2, 2022
@fm3 fm3 mentioned this pull request Sep 4, 2022
Open
12 tasks
@fm3 fm3 marked this pull request as ready for review September 4, 2022 13:55
@fm3 fm3 changed the title [WIP] some enhancements for editable mappings Fix duplicate route for Editable Mapping annotations Sep 4, 2022
@fm3 fm3 requested a review from leowe September 4, 2022 13:56
leowe
leowe approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@leowe leowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@fm3 fm3 merged commit 387a22f into master Sep 12, 2022
@fm3 fm3 deleted the editable-mapping-improvements branch September 12, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leowe leowe leowe approved these changes

Assignees

@fm3 fm3

Labels
backend enhancement proofreading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fm3 @leowe