Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed "clip histogram" button not resetting in some cases #6407

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Aug 16, 2022

This PR fix a small issue with an AsyncButton for clipping the histogram not resetting to it's "base"/cklickable state in some case but instead "loading"/"spinning" forever.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Move to an area with no data ("black")
  • Click "clip histogram" button
  • Oberserve that the button turns into a spinner and returns to its base state ready for clicking again

Issues:


(Please delete unneeded items, merge only when none are left open)

@hotzenklotz hotzenklotz self-assigned this Aug 16, 2022
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you for debugging this 👍

@hotzenklotz hotzenklotz enabled auto-merge (squash) August 16, 2022 12:11
@hotzenklotz hotzenklotz changed the title Fixed "clip histogram" button not resetting in some casese Fixed "clip histogram" button not resetting in some cases Aug 16, 2022
@hotzenklotz hotzenklotz merged commit 93eb6e4 into master Aug 16, 2022
@hotzenklotz hotzenklotz deleted the fix_histogram_button branch August 16, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After histogram clipping fails (e.g. no data in viewport), button stays disabled
2 participants