Return 404 for not-found zarr chunks #6381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fm3
approved these changes
Aug 6, 2022
| @@ -212,7 +212,8 @@ class ZarrStreamingController @Inject()( | |||
| ), | |||
| DataServiceRequestSettings(halfByte = false) | |||
| ) | |||
| (data, _) <- binaryDataService.handleDataRequests(List(request)) | |||
| (data, notFoundIndices) <- binaryDataService.handleDataRequests(List(request)) | |||
| _ <- bool2Fox(notFoundIndices.size == 0) ~> "zarr.chunkNotFound" ~> 404 | |||
There was a problem hiding this comment.
Suggested change
| _ <- bool2Fox(notFoundIndices.size == 0) ~> "zarr.chunkNotFound" ~> 404 | |
| _ <- bool2Fox(notFoundIndices.isEmpty) ~> "zarr.chunkNotFound" ~> NOT_FOUND |
(possibly, NOT_FOUND needs to be be imported from play.api.http.Status.NOT_FOUND)
There was a problem hiding this comment.
The other lines above also use ~> 404 should I replace them all?
|
Seems to me |
fm3
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return 404 for not-found zarr chunks. Not sure if this plays well with the other currently in-review PRs for Zarr. Happy to close this one again, if you think that makes sense. I was just curious how a fix could be implemented.
Steps to test:
l4_sampledataset and set it to "public":curl -I http://localhost:9000/data/zarr/sample_organization/l4_sample/color/1-1-1/0.112.112.32-> 200 Okcurl -I http://localhost:9000/data/zarr/sample_organization/l4_sample/color/1-1-1/0.0.0.0-> 404 Not foundIssues:
(Please delete unneeded items, merge only when none are left open)