Fix mapping activation confirmation #6346
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A breaking change in an antd minor version update led to the Popconfirm no longer appearing before/after the context menu was hidden. I did not succeed trying to stop the propagation of the event that hides the context menu and even if that would've worked, the context menu would've had to be closed manually after the Popconfirm was canceled/confirmed.
Instead, I switched to a
Modal.confirm
which appears even after the context menu is hidden, shows a spinner while the async action inonConfirm
is performed and arguably looks better :)URL of deployed dev instance (used for testing):
Steps to test:
test-agglomerate-file
dataset)(Please delete unneeded items, merge only when none are left open)