Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mapping activation confirmation #6346

Merged
merged 3 commits into from
Jul 25, 2022
Merged

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Jul 21, 2022

A breaking change in an antd minor version update led to the Popconfirm no longer appearing before/after the context menu was hidden. I did not succeed trying to stop the propagation of the event that hides the context menu and even if that would've worked, the context menu would've had to be closed manually after the Popconfirm was canceled/confirmed.

Instead, I switched to a Modal.confirm which appears even after the context menu is hidden, shows a spinner while the async action in onConfirm is performed and arguably looks better :)

URL of deployed dev instance (used for testing):

Steps to test:

  • Open a dataset with a meshfile that was computed for a specific agglomerate file (test-agglomerate-file dataset)
  • Rightclick on a segment - Load Mesh (precomputed)
    • There should be a confirmation modal which activates the respective mapping before loading the mesh iff it is confirmed
    • If the correct mapping is activated already, no confirmation modal should be shown
  • Do the same from the segments list

(Please delete unneeded items, merge only when none are left open)

…mation due to breaking change in antd which led to the Popconfirm not appearing before/after the context menu was hidden
@daniel-wer daniel-wer self-assigned this Jul 21, 2022
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :) This is probably the cleanest fix 👍

@bulldozer-boy bulldozer-boy bot merged commit bb4dbab into master Jul 25, 2022
@bulldozer-boy bulldozer-boy bot deleted the fix-mapping-confirm branch July 25, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants