Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve convert to hybrid workflow #6330

Merged
merged 18 commits into from
Jul 21, 2022
Merged

Improve convert to hybrid workflow #6330

merged 18 commits into from
Jul 21, 2022

Conversation

Dagobert42
Copy link
Contributor

@Dagobert42 Dagobert42 commented Jul 13, 2022 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • create a volume-only annotation
  • Annotation Type: X is removed from info tab
  • the layers tab now displays an Add Skeleton Annotation Layer button with the old convert to hybrid functionality
  • segmentation layers which were not previously editable now show an (un)lock icon button which shortcuts to the "add volume layer" modal with the layer being preselected
  • should be disallowed for tasks

Issues:

(Please delete unneeded items, merge only when none are left open)

@Dagobert42 Dagobert42 self-assigned this Jul 20, 2022
@Dagobert42 Dagobert42 changed the title Improve convert to hybrid workflow [WIP] Improve convert to hybrid workflow Jul 20, 2022
@Dagobert42 Dagobert42 changed the title [WIP] Improve convert to hybrid workflow Improve convert to hybrid workflow Jul 20, 2022
philippotto
philippotto requested changes Jul 20, 2022
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff 👍 See my comments :)

frontend/javascripts/oxalis/view/left-border-tabs/modals/add_volume_layer_modal.tsx Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/view/left-border-tabs/modals/add_volume_layer_modal.tsx Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/view/left-border-tabs/modals/add_volume_layer_modal.tsx Outdated Show resolved Hide resolved
frontend/javascripts/components/hover_icon_button.tsx Show resolved Hide resolved
frontend/javascripts/oxalis/view/left-border-tabs/layer_settings_tab.tsx Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/view/left-border-tabs/layer_settings_tab.tsx Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/view/left-border-tabs/layer_settings_tab.tsx Outdated Show resolved Hide resolved
@Dagobert42
code review changes 1/2
9273dcf
@Dagobert42
code review changes 2/2
c3478cf 
passing layer names instead of indices
philippotto
philippotto approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍 Works well for me. I don't think you need it to test it with another DS, since the new by-name logic should be way safer than the by-index logic.

@philippotto
Copy link
Member

But please update the changelog before merging ;)

@Dagobert42 Dagobert42 merged commit a14820d into master Jul 21, 2022
@Dagobert42 Dagobert42 deleted the improve-convert-to-hybrid-workflow branch July 21, 2022 13:05
@fm3 fm3 mentioned this pull request Jul 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@Dagobert42 Dagobert42

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve "convert to hybrid" flow with regard to segmentation layers
2 participants
@Dagobert42 @philippotto