Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Annotation Layer Names Unique in DB #6326

Merged
merged 6 commits into from
Jul 11, 2022
Merged

Make Annotation Layer Names Unique in DB #6326

merged 6 commits into from
Jul 11, 2022

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jul 11, 2022

The Front-end already enforces unique url-safe layer names as of #6289 – this PR adds the same constraints in the back-end.
Note that the evolution is not fully automatic this time (would have become complex). Instead, instructions are added to the migration guide on how to manually migrate the db content.

Some backend changes followed from the name now being non-optional.

Additionally, The layer name displayed by the front-end for Skeleton Annotation Layers is changed from »Skeletons« to »Skeleton« as discussed here – Note that in the Skeleton case, the front-end does not use or set the annotation layer name from the DB, but instead uses this string. This is a special case enabled by the fact that there is currently always at most one skeleton layer.

Steps to test:

  • evolutions should be equal to schema (asserted by CI)
  • users should be able to set volume layer names according to the constraints

Issues:


@fm3 fm3 requested a review from jstriebel July 11, 2022 10:10
@fm3 fm3 self-assigned this Jul 11, 2022
@fm3 fm3 removed the request for review from jstriebel July 11, 2022 10:26
Copy link
Contributor

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

tools/postgres/schema.sql Show resolved Hide resolved
@fm3 fm3 merged commit 5b0944c into master Jul 11, 2022
@fm3 fm3 deleted the layer-names branch July 11, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make annotation layer names unique per annotation
2 participants