Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use valid name as the default volume layer name #6321

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Use valid name as the default volume layer name #6321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a080f19
Use valid name as the default volume layer name
daniel-wer Jul 7, 2022
3c5e7b4
fix typo and update changelog
daniel-wer Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.unreleased.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released

### Changed
- Merged the "Shared Annotations" tab into the "Annotations" tab in the user's dashboard. If annotations are shared with you, you can see them in your dashboard. The table can be filtered by owner if you prefer to see only your own annotations. [#6230](https://github.com/scalableminds/webknossos/pull/6230)
- Changed the name of the volume annotation layer in tasks to be "Volume" instead of "Volume Layer". [#6321](https://github.com/scalableminds/webknossos/pull/6321)

### Fixed
- Fixed that zooming out for datasets with very large scale was not possible until the coarsest level. [#6304](https://github.com/scalableminds/webknossos/pull/6304)
Expand Down
2 changes: 1 addition & 1 deletion frontend/javascripts/oxalis/model/accessors/volumetracing_accessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export function getReadableNameByVolumeTracingId(
tracingId: string,
) {
const volumeDescriptor = getVolumeDescriptorById(tracing, tracingId);
return volumeDescriptor.name || "Volume Layer";
return volumeDescriptor.name || "Volume";
}

export function getAllReadableLayerNames(dataset: APIDataset, tracing: Tracing) {
Expand Down
6 changes: 3 additions & 3 deletions frontend/javascripts/oxalis/view/right-border-tabs/export_bounding_box_modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,12 @@ export function getLayerInfos(
// Satisfy flow.
throw new Error("Tracing is null, but layer.tracingId is defined.");
}
const readbleVolumeLayerName = getReadableNameOfVolumeLayer(layer, tracing) || "Volume Layer";
const readableVolumeLayerName = getReadableNameOfVolumeLayer(layer, tracing) || "Volume";
const volumeTracing = getVolumeTracingById(tracing, layer.tracingId);

if (layer.fallbackLayerInfo != null) {
return {
displayName: readbleVolumeLayerName,
displayName: readableVolumeLayerName,
layerName: layer.fallbackLayerInfo.name,
tracingId: volumeTracing.tracingId,
annotationId,
Expand All @@ -93,7 +93,7 @@ export function getLayerInfos(
}

return {
displayName: readbleVolumeLayerName,
displayName: readableVolumeLayerName,
layerName: null,
tracingId: volumeTracing.tracingId,
annotationId,
Expand Down