2nd attempt: Merge "Shared Annotations" with "My annotations" #6287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jstriebel could you have a look here at the latest commits? after broadening the access context, which solved the 404 error, the second bug was that annotations that were public were also listed on this page. however, the semantics of “public” is really “unlisted” (since such a list did not exist before and we cannot just change that semantics as it was communicated like this to the users). so now I added a separate list access query. i also added a slight performance improvement for fetching shared teams from the db |
jstriebel
reviewed
Jul 6, 2022
This was referenced Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt to merge #6230. However, there seems to be a bug with the
annotations/readableroute which fails sometimes with a 404 status.https://webknossos.org/api/annotations/readable?isFinished=false&pageNumber=0 failed for me in prod (isFinished=true worked).