Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow all resolutions if there is no volume annotation in the nml #6116

Merged
merged 7 commits into from
Mar 23, 2022
Merged

allow all resolutions if there is no volume annotation in the nml #6116

merged 7 commits into from
Mar 23, 2022

Conversation

leowe
Copy link
Contributor

@leowe leowe commented Mar 16, 2022 •
edited
Loading

  • When uploading a NML check whether there are any volume annotations, if there are none, allow all resolutions
  • add leowe to slack notifications
  • fix small language mistake
  • change logger.error to logger.warn for filesystem checking for the data set indexing

URL of deployed dev instance (used for testing):

Steps to test:

  • Open any dataset (e.g. l4_sample)
  • Create a empty annotation, download it, and then drag and drop it in the view (or use this empty annotation)
  • A new annotation should open without an error message

Issues:

(Please delete unneeded items, merge only when none are left open)

@leowe leowe requested a review from fm3 March 16, 2022 13:59
@leowe leowe self-assigned this Mar 16, 2022
@leowe leowe added the backend label Mar 16, 2022
fm3
fm3 reviewed Mar 16, 2022
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff, I like that you also fixed a few small things along the way! :D
I added a suggestion for performance optimization.

@leowe leowe requested a review from fm3 March 18, 2022 13:52
fm3
fm3 approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

leowe and others added 2 commits March 23, 2022 09:41
@leowe leowe merged commit 322a2b4 into master Mar 23, 2022
@leowe leowe deleted the empty-tracing branch March 23, 2022 10:39
@fm3 fm3 mentioned this pull request Apr 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

Assignees

@leowe leowe

Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uploading annotation zip with empty volume layers leads to error
2 participants
@leowe @fm3